[PATCH net-next 24/33] net: bcmasp: Remove comma after sentinel-entry in match-table
Loktionov, Aleksandr
aleksandr.loktionov at intel.com
Tue Sep 8 06:33:11 PDT 2026
> -----Original Message-----
> From: Siddharth Vadapalli <s-vadapalli at ti.com>
> Sent: Friday, September 4, 2026 6:37 AM
> To: dario.binacchi at amarulasolutions.com; mkl at pengutronix.de;
> mailhol at kernel.org; msp at baylibre.com; florian.fainelli at broadcom.com;
> jonas.gorski at gmail.com; andrew at lunn.ch; olteanv at gmail.com;
> davem at davemloft.net; edumazet at google.com; kuba at kernel.org;
> pabeni at redhat.com; kurt at linutronix.de; hauke at hauke-m.de;
> chester.a.unal at arinc9.com; daniel at makrotopia.org;
> matthias.bgg at gmail.com; angelogioacchino.delregno at collabora.com;
> ansuelsmth at gmail.com; linusw at kernel.org; luizluca at gmail.com;
> alvin.sipraga at analog.com; clement.leger at bootlin.com;
> justin.chen at broadcom.com; dlan at kernel.org; rogerq at kernel.org;
> hkallweit1 at gmail.com; linux at armlinux.org.uk; rjui at broadcom.com;
> sbranden at broadcom.com; bcm-kernel-feedback-list at broadcom.com;
> opendmb at gmail.com; andrei.botila at oss.nxp.com; wangruikang at iscas.ac.cn;
> amadeus at jmu.edu.cn; kees at kernel.org; tmshlvck at gmail.com; c-
> vankar at ti.com; horms at kernel.org; vadim.fedorenko at linux.dev;
> daniel.zahka at gmail.com; nora.schiffer at ew.tq-group.com; v-
> singh1 at ti.com; oss at vassilevski.com; haokexin at gmail.com;
> alex at sverdlin.org; Loktionov, Aleksandr
> <aleksandr.loktionov at intel.com>; lgs201920130244 at gmail.com
> Cc: linux-can at vger.kernel.org; netdev at vger.kernel.org; linux-
> kernel at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-
> mediatek at lists.infradead.org; linux-renesas-soc at vger.kernel.org;
> linux-riscv at lists.infradead.org; spacemit at lists.linux.dev; linux-
> omap at vger.kernel.org; s-vadapalli at ti.com
> Subject: [PATCH net-next 24/33] net: bcmasp: Remove comma after
> sentinel-entry in match-table
>
> Since sentinel is the last entry and we do not expect further entries
> following it, remove the comma.
>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli at ti.com>
> ---
> drivers/net/ethernet/broadcom/asp2/bcmasp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> b/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> index 972474893a6b..3393b5dcbc9a 100644
> --- a/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> @@ -1209,7 +1209,7 @@ static const struct of_device_id
> bcmasp_of_match[] = {
> { .compatible = "brcm,asp-v2.1", .data = &v21_plat_data },
> { .compatible = "brcm,asp-v2.2", .data = &v22_plat_data },
> { .compatible = "brcm,asp-v3.0", .data = &v30_plat_data },
> - { /* sentinel */ },
> + { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, bcmasp_of_match);
>
> @@ -1217,7 +1217,7 @@ static const struct of_device_id
> bcmasp_mdio_of_match[] = {
> { .compatible = "brcm,asp-v2.1-mdio", },
> { .compatible = "brcm,asp-v2.2-mdio", },
> { .compatible = "brcm,asp-v3.0-mdio", },
> - { /* sentinel */ },
> + { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, bcmasp_mdio_of_match);
>
> --
> 2.51.1
For me it looks like this PR doesn't clean up anything meaningful.
Is there a different opinion?
More information about the Linux-mediatek
mailing list