[PATCH nf-next v3 2/3] netfilter: flowtable: carry a priority into the offload

[Julius Bairaktaris]

> Does this silently ignore explicit QoS queuing requests from TC flower?

Yes, and the commit message says so. mtk gets tc flower rules and
flowtable flows through the same block callback, so
mtk_flow_offload_replace() cannot reject one and accept the other.

Rejecting the action would stop offload for every IPv4 flow with a
non-zero TOS, because ip_forward() sets the priority from the TOS by
default:

    net/ipv4/ip_forward.c, ip_forward():
        if (READ_ONCE(net->ipv4.sysctl_ip_fwd_update_priority))
                skb->priority = rt_tos2priority(iph->tos);

A flow forwarded by the mtk PPE does not go through the egress qdisc, so
the priority has nothing to select there. mtk already accepts and
ignores FLOW_ACTION_CSUM in the same way.

No change planned for this one.