[PATCH 1/4] pinctrl: airoha: Remove redundant dev_err()
Lorenzo Bianconi
lorenzo at kernel.org
Mon Jul 20 04:12:50 PDT 2026
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang at vivo.com>
Acked-by: Lorenzo Bianconi <lorenzo at kernel.org>
> ---
> drivers/pinctrl/airoha/pinctrl-airoha.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/airoha/pinctrl-airoha.c b/drivers/pinctrl/airoha/pinctrl-airoha.c
> index 04b4424c688b..abfb018f207e 100644
> --- a/drivers/pinctrl/airoha/pinctrl-airoha.c
> +++ b/drivers/pinctrl/airoha/pinctrl-airoha.c
> @@ -2519,10 +2519,8 @@ static int airoha_pinctrl_add_gpiochip(struct airoha_pinctrl *pinctrl,
>
> err = devm_request_irq(dev, irq, airoha_irq_handler, IRQF_SHARED,
> dev_name(dev), pinctrl);
> - if (err) {
> - dev_err(dev, "error requesting irq %d: %d\n", irq, err);
> + if (err)
> return err;
> - }
>
> return devm_gpiochip_add_data(dev, gc, pinctrl);
> }
> --
> 2.34.1
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-mediatek/attachments/20260720/b73c2bb4/attachment-0001.sig>
More information about the Linux-mediatek
mailing list