[External Mail] Re: [PATCH v4 2/7] net: wwan: t9xx: Add control plane transaction layer

[Wu. JackBB (GSM)]

Hi Simon,

After further internal review, we agree this needs to be fixed.

On Jack Wu wrote:

>> [Severity: High]
>> Does this code apply a double byte-swap on big-endian architectures?

>T9XX currently only targets x86 (little-endian) platforms where
>cpu_to_le32() is a no-op. The Kconfig enforces "depends on PCI &&

In v5 we will remove LE32_TO_U32(cpu_to_le32(...)) and return
hw_bits directly in both mtk_pci_ext_d2h_evt_hw_bits() and
mtk_pci_ext_h2d_evt_hw_bits(). The custom LE32_TO_U32 macro
will also be removed.

Thanks.

Jack Wu