[PATCH wireless-next v2 0/2] wifi: mt76: fix per-band LEDs under single-wiphy MLO
Petr Wozniak
petr.wozniak at gmail.com
Tue Jul 14 03:26:13 PDT 2026
On MT7996 (and other single-wiphy MLO mt76 devices) only the 2.4 GHz LED
was ever usable: the 5/6 GHz band LEDs stayed dark and a WARN_ON() was hit
during probe.
Two issues are involved:
1. mt76_led_init() calls ieee80211_create_tpt_led_trigger() for every band,
but that helper supports only one trigger per ieee80211_hw and
WARN_ON()s + returns NULL on the second call, so the secondary bands got
a NULL default trigger.
2. mt7996 assigned the LED brightness_set/blink_set callbacks only to the
primary PHY, so mt76_led_init() bailed out early for the 5/6 GHz bands
and never registered their LED classdevs.
Patch 1 shares the throughput trigger across all bands; patch 2 registers a
LED classdev for every band. With both applied, all three band LEDs
(mt76-phy0/1/2) come up and blink on their band's traffic.
Tested on a BPI-R4 (MT7996/BE14): all three per-band LEDs register at boot
with no WARN_ON(), and each blinks on its own band's activity (verified
with single-band and MLO clients).
Changes in v2:
- Patch 1: reflow the throughput-trigger comment and wrap the
ieee80211_create_tpt_led_trigger() arguments to stay within 80 columns
(no functional change).
- Cc the MediaTek SoC/wireless maintainers reported by get_maintainer.pl.
- No code changes since v1.
v1: https://lore.kernel.org/all/20260628095313.7790-1-petr.wozniak@gmail.com/
Petr Wozniak (2):
wifi: mt76: share the throughput LED trigger across bands
wifi: mt76: mt7996: register a LED classdev for every band
drivers/net/wireless/mediatek/mt76/mac80211.c | 18 +++++++++++++-----
.../net/wireless/mediatek/mt76/mt7996/init.c | 18 ++++++++++++------
2 files changed, 25 insertions(+), 11 deletions(-)
--
2.51.0
More information about the Linux-mediatek
mailing list