[PATCH net-next 2/6] net: stmmac: mediatek: add PERI_ETH_CTRLx register offset in platform data
Louis-Alexis Eyraud
louisalexis.eyraud at collabora.com
Wed Jul 8 04:44:36 PDT 2026
Hi Andrew
On Tue, 2026-07-07 at 14:45 +0200, Andrew Lunn wrote:
> > + .peri_eth_ctrl_offset = MT8195_PERI_ETH_CTRL_BASE,
>
> nitpick:
>
> Could the naming be more consistent? offset vs base?
>
> Andrew
Ack.
The commit description and subject also use offset terminology and not
base so better keep the consistency.
I'll rename this define to MT8195_PERI_ETH_CTRL_OFFSET in the v2
version and do the same for the MT8189 one in patch 6.
Regards,
Louis-Alexis
More information about the Linux-mediatek
mailing list