[PATCH] media: platform: mtk-mdp3: fix NULL deref on failed SCP lookup

Johan Hovold johan at kernel.org
Sun Jul 5 23:59:27 PDT 2026


Add the missing sanity check after looking up the SCP to avoid
dereferencing a NULL-pointer in case its driver has not yet been bound.

Fixes: 61890ccaefaf ("media: platform: mtk-mdp3: add MediaTek MDP3 driver")
Cc: stable at vger.kernel.org	# 6.1
Cc: Moudy Ho <moudy.ho at mediatek.com>
Signed-off-by: Johan Hovold <johan at kernel.org>
---

This one applies on top of Guangshuo's fix:

	https://lore.kernel.org/r/20260704173119.254975-1-lgs201920130244@gmail.com

Johan


 drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c
index 121b1006ffdc..f412aadb5996 100644
--- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c
+++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c
@@ -296,6 +296,11 @@ static int mdp_probe(struct platform_device *pdev)
 		mdp->scp = platform_get_drvdata(mm_pdev);
 	}
 
+	if (!mdp->scp) {
+		ret = -EPROBE_DEFER;
+		goto err_destroy_clock_wq;
+	}
+
 	mdp->rproc_handle = scp_get_rproc(mdp->scp);
 	dev_dbg(&pdev->dev, "MDP rproc_handle: %p", mdp->rproc_handle);
 
-- 
2.54.0




More information about the Linux-mediatek mailing list