[PATCH 45/45] clk: zynqmp: Make sure clk_init_data is fully initialized
Geert Uytterhoeven
geert+renesas at glider.be
Fri Aug 21 01:53:55 PDT 2026
The clk_init_data structure contains several mutually-exclusive members
for different methods to specify the possible parents of a clock,
prompting drivers to initialize only the members they need. However,
not initializing all members may cause subtle issues, which are only
exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is
enabled.
Make sure all members are fully initialized, to avoid such bugs, and to
prevent future breakage when converting drivers to a different method
for specifying the parents.
Signed-off-by: Geert Uytterhoeven <geert+renesas at glider.be>
---
Compile-tested only.
---
drivers/clk/zynqmp/clk-gate-zynqmp.c | 2 +-
drivers/clk/zynqmp/clk-mux-zynqmp.c | 2 +-
drivers/clk/zynqmp/divider.c | 2 +-
drivers/clk/zynqmp/pll.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/zynqmp/clk-gate-zynqmp.c b/drivers/clk/zynqmp/clk-gate-zynqmp.c
index db10eb69f3fe01a5..1a462af7b8ea3efa 100644
--- a/drivers/clk/zynqmp/clk-gate-zynqmp.c
+++ b/drivers/clk/zynqmp/clk-gate-zynqmp.c
@@ -109,10 +109,10 @@ struct clk_hw *zynqmp_clk_register_gate(const char *name, u32 clk_id,
u8 num_parents,
const struct clock_topology *nodes)
{
+ struct clk_init_data init = {};
struct zynqmp_clk_gate *gate;
struct clk_hw *hw;
int ret;
- struct clk_init_data init;
/* allocate the gate */
gate = kzalloc_obj(*gate);
diff --git a/drivers/clk/zynqmp/clk-mux-zynqmp.c b/drivers/clk/zynqmp/clk-mux-zynqmp.c
index e37bd3516974c1ee..79509e387b51fe40 100644
--- a/drivers/clk/zynqmp/clk-mux-zynqmp.c
+++ b/drivers/clk/zynqmp/clk-mux-zynqmp.c
@@ -133,9 +133,9 @@ struct clk_hw *zynqmp_clk_register_mux(const char *name, u32 clk_id,
u8 num_parents,
const struct clock_topology *nodes)
{
+ struct clk_init_data init = {};
struct zynqmp_clk_mux *mux;
struct clk_hw *hw;
- struct clk_init_data init;
int ret;
mux = kzalloc_obj(*mux);
diff --git a/drivers/clk/zynqmp/divider.c b/drivers/clk/zynqmp/divider.c
index 4075f6ecf076a8e6..3eabd1cf211ddba3 100644
--- a/drivers/clk/zynqmp/divider.c
+++ b/drivers/clk/zynqmp/divider.c
@@ -278,9 +278,9 @@ struct clk_hw *zynqmp_clk_register_divider(const char *name,
u8 num_parents,
const struct clock_topology *nodes)
{
+ struct clk_init_data init = {};
struct zynqmp_clk_divider *div;
struct clk_hw *hw;
- struct clk_init_data init;
int ret;
/* allocate the divider */
diff --git a/drivers/clk/zynqmp/pll.c b/drivers/clk/zynqmp/pll.c
index 6463787cf57b6018..6158386ca743d1f8 100644
--- a/drivers/clk/zynqmp/pll.c
+++ b/drivers/clk/zynqmp/pll.c
@@ -313,9 +313,9 @@ struct clk_hw *zynqmp_clk_register_pll(const char *name, u32 clk_id,
u8 num_parents,
const struct clock_topology *nodes)
{
+ struct clk_init_data init = {};
struct zynqmp_pll *pll;
struct clk_hw *hw;
- struct clk_init_data init;
int ret;
init.name = name;
--
2.43.0
More information about the Linux-mediatek
mailing list