[PATCH v2 1/3] ASoC: mediatek: mt6797: fix wrong unwind order and error code in enable_clock
Bui Duc Phuc
phucduc.bui at gmail.com
Thu Aug 20 04:21:55 PDT 2026
Hi Cezary,
Thank you for your review.
>
> There is no changelog in this series so reviewers have harder job
> analyzing the v2 patches. If there is no cover-letter, you can always
> paste the update here, after '---'.
>
> In regard to the patch, the fix looks good - given the number of errors
> in the existing code with invalid return code on top, perhaps someone
> wanted the function to be permissive.
>
> Otherwise it's just bunch of untested stuff and your change should be
> tagged with: Fixes: and propagated downstream.
>
> Reviewed-by: Cezary Rojewski <cezary.rojewski at intel.com>
I’ll add the Fixes: tag and include a changelog
for the changes in the next revision.
Best regards,
Phuc
More information about the Linux-mediatek
mailing list