[PATCH 2/4] ASoC: mediatek: mt8183: Fix APLL enable error handling

Bui Duc Phuc phucduc.bui at gmail.com
Wed Aug 19 18:57:05 PDT 2026


Hi Mark,

Thank you for your review.

> > -     apll1_mux_setting(afe, true);
> > +     ret = apll1_mux_setting(afe, true);
> > +     if (ret) {
> > +             dev_err(afe->dev, "%s apll1_mux_setting fail %d\n",
> > +                     __func__, ret);
> > +             goto ERR_APLL1_MUX_SETTING;
> > +     }
>
> apll1_mux_setting() logs errors, do we need to add another log?

Oh, sorry, this was an oversight on my part. The apll1_mux_setting()
function already logs the error,
so there is no need to add another error message here.
I’ll send v2 shortly.

Best regards,
Phuc



More information about the Linux-mediatek mailing list