[External Mail] Re: [PATCH v6 2/7] net: wwan: t9xx: Add control plane transaction layer

[Wu. JackBB (GSM)]

On Mon, 17 Aug 2026 at 22:36, Jakub Kicinski <kuba at kernel.org> wrote:
> [Severity: Low]
> Should the commit message mention this module split?  Before this patch
...
> so the module that binds the hardware and carries the PCI modaliases is
> now mtk_t9xx_pcie.ko, while mtk_t9xx.ko only holds mtk_dev.o and
> mtk_ctrl_plane.o with no driver registration.

Will fix in v7. Will update the commit message to mention the module
split, and update the Kconfig help text to name both mtk_t9xx and
mtk_t9xx_pcie.

> [Severity: Low]
> Does the kernel-doc for mtk_ctrl_exit() match what the function does?  The
> comment says "Frees the control plane block associated with @mdev", but the
> body only clears the pointer:
...
> Could the doc be reworded to say the pointer is cleared and the
> allocation is released by devres, so a later patch adding an explicit
> devm_kfree() does not end up double freeing it?

Will fix in v7. Will reword the kernel-doc to: "Clears the control
plane block pointer. The allocation itself is managed by devres and
freed on driver detach."

Thanks.

--
Jack