[PATCH v1] ufs: core: Change MCQ interrupt enable flow

Peter Wang (王信友) peter.wang at mediatek.com
Wed Sep 24 02:13:17 PDT 2025


On Tue, 2025-09-23 at 08:54 -0700, Bart Van Assche wrote:
> 
> On 9/23/25 2:08 AM, peter.wang at mediatek.com wrote:
> > -static void ufshcd_enable_intr(struct ufs_hba *hba, u32 intrs)
> > +void ufshcd_enable_intr(struct ufs_hba *hba, u32 intrs)
> >   {
> >       u32 old_val = ufshcd_readl(hba, REG_INTERRUPT_ENABLE);
> >       u32 new_val = old_val | intrs;
> > @@ -377,6 +372,7 @@ static void ufshcd_enable_intr(struct ufs_hba
> > *hba, u32 intrs)
> >       if (new_val != old_val)
> >               ufshcd_writel(hba, new_val, REG_INTERRUPT_ENABLE);
> >   }
> > +EXPORT_SYMBOL_GPL(ufshcd_enable_intr);
> 
> Please do not export ufshcd_enable_intr() - this function should not
> be
> called from outside the UFS driver core.
> 
> Thanks,
> 
> Bart.

Hi Bart,

Okay, I will remove this next version.

Thanks.
Peter



More information about the Linux-mediatek mailing list