[PATCH v1 06/10] ufs: host: mediatek: Enable interrupts for MCQ mode
Peter Wang (王信友)
peter.wang at mediatek.com
Fri Sep 19 01:14:54 PDT 2025
On Thu, 2025-09-18 at 11:34 -0700, Bart Van Assche wrote:
> On 9/18/25 3:36 AM, peter.wang at mediatek.com wrote:
> > Enable interrupts in MCQ mode before making the host
> > operational in the UFS Mediatek driver. This ensures proper
> > handling of task request completions and error conditions.
>
> All interrupt enable / disable code should occur in the UFS core
> driver.
> Please do not add any code in host drivers that manipulates the
> interrupt status.
>
Hi Bart,
Because ufshcd_make_hba_operational only enables UFSHCD_ENABLE_INTRS,
there are no MCQ-related interrupts enabled.
MCQ interrupts are only enabled in ufshcd_config_mcq.
So, should we also add these MCQ interrupts in
ufshcd_make_hba_operational?
> Additionally, the above patch description doesn't make it clear what
> makes the MediaTek driver different from other drivers and why only
> the
> MediaTek driver needs this change.
>
> Thanks,
>
> Bart.
This is a confidential design by MediaTek, so we are unable
to share further details. We apologize for the inconvenience.
Thanks.
Peter
More information about the Linux-mediatek
mailing list