[PATCH v2 1/2] tty: serial: 8250_mtk: enable baud clock

Andy Shevchenko andriy.shevchenko at linux.intel.com
Mon Sep 15 07:54:03 PDT 2025


On Mon, Sep 15, 2025 at 02:06:37PM +0100, Daniel Golle wrote:

...

> -		data->uart_clk = devm_clk_get(&pdev->dev, NULL);
> +		data->uart_clk = devm_clk_get_enabled(&pdev->dev, NULL);
>  		if (IS_ERR(data->uart_clk)) {
>  			dev_warn(&pdev->dev, "Can't get uart clock\n");
>  			return PTR_ERR(data->uart_clk);

Consider making this to be either dev_warn_once() / _ratelimited() or
better to have

	return dev_err_probe(...);

This will allow to avoid flooding the logs when clock is not yet ready.
The proposed change can be done in the separate patch.

-- 
With Best Regards,
Andy Shevchenko





More information about the Linux-mediatek mailing list