[PATCH v1 01/14] media: dt-bindings: Convert MediaTek mt8173-mdp bindings to YAML

[Ariel D'Alessandro]

Krzysztof,

On 9/9/25 3:32 AM, Krzysztof Kozlowski wrote:
> On 08/09/2025 19:52, Ariel D'Alessandro wrote:
>> Krzysztof,
>>
>> On 8/21/25 3:46 AM, Krzysztof Kozlowski wrote:
>>> On Wed, Aug 20, 2025 at 02:12:49PM -0300, Ariel D'Alessandro wrote:

[...]

>>>> +          - enum:
>>>> +              - mediatek,mt8173-mdp-rdma
>>>> +              - mediatek,mt8173-mdp-rsz
>>>> +              - mediatek,mt8173-mdp-wdma
>>>> +              - mediatek,mt8173-mdp-wrot
>>>> +      - items:
>>>> +          - enum:
>>>> +              - mediatek,mt8173-mdp-rdma
>>>> +              - mediatek,mt8173-mdp-rsz
>>>> +              - mediatek,mt8173-mdp-wdma
>>>> +              - mediatek,mt8173-mdp-wrot
>>>> +          - const: mediatek,mt8173-mdp
>>>
>>> This makes no sense. How devices can be compatible and can not be
>>> compatible.
>>
>> According to the driver source code (and the previous txt mt8173-mdp
>> bindings), there must be a "controller node" with compatible
>> `mediatek,mt8173-mdp`. Then its sibling nodes (including itself) should
> 
> But you did not define "mediatek,mt8173-mdp" here, so what are you
> talking about?
> 
> I talk here about "wrot" and others, I thought it is obvious from the
> mistake in the schema.

Ack.

[...]

>>>> +
>>>> +  - if:
>>>> +      properties:
>>>> +        compatible:
>>>> +          contains:
>>>> +            const: mediatek,mt8173-mdp
>>>
>>> This makes no sense either.
>>
>> Same question above about compatibles.
> 
> How same question? Do you understand this code? It is nothing the same -
> you have here contains!


Ack. Will resubmit properly in v2.

Thanks,

-- 
Ariel D'Alessandro
Software Engineer

Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK 
Registered in England & Wales, no. 5513718