[PATCH] wifi: mt76: mt7996: fix FCS error flag check in RX descriptor
AngeloGioacchino Del Regno
angelogioacchino.delregno at collabora.com
Mon Oct 13 02:23:24 PDT 2025
Il 13/10/25 11:08, Alok Tiwari ha scritto:
> The mt7996 driver currently checks the MT_RXD3_NORMAL_FCS_ERR bit in
> rxd1 whereas other Connac3-based drivers(mt7925) correctly check this
> bit in rxd3.
>
> Since the MT_RXD3_NORMAL_FCS_ERR bit is defined in the fourth RX
> descriptor word (rxd3), update mt7996 to use the proper descriptor
> field. This change aligns mt7996 with mt7925 and the rest of the
> Connac3 family.
>
> Fixes: 98686cd21624 ("wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices")
> Signed-off-by: Alok Tiwari <alok.a.tiwari at oracle.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno at collabora.com>
> ---
> drivers/net/wireless/mediatek/mt76/mt7996/mac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mac.c b/drivers/net/wireless/mediatek/mt76/mt7996/mac.c
> index 9501def3e0e3..59744e5593b6 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7996/mac.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7996/mac.c
> @@ -527,7 +527,7 @@ mt7996_mac_fill_rx(struct mt7996_dev *dev, enum mt76_rxq_id q,
> !(csum_status & (BIT(0) | BIT(2) | BIT(3))))
> skb->ip_summed = CHECKSUM_UNNECESSARY;
>
> - if (rxd1 & MT_RXD3_NORMAL_FCS_ERR)
> + if (rxd3 & MT_RXD3_NORMAL_FCS_ERR)
> status->flag |= RX_FLAG_FAILED_FCS_CRC;
>
> if (rxd1 & MT_RXD1_NORMAL_TKIP_MIC_ERR)
More information about the Linux-mediatek
mailing list