[PATCH v3 2/2] net: dsa: mt7530: Use GPIO polarity to generate correct reset sequence
Andrew Lunn
andrew at lunn.ch
Sat Nov 29 17:11:05 PST 2025
> - gpiod_set_value_cansleep(priv->reset, 0);
> + int is_active_low = !!gpiod_is_active_low(priv->reset);
> + gpiod_set_value_cansleep(priv->reset, is_active_low);
I think you did not correctly understand what Russell said. You pass
the logical value to gpiod_set_value(). If the GPIO has been marked as
active LOW, the GPIO core will invert the logical values to the raw
value. You should not be using gpiod_is_active_low().
But as i said to the previous patch, i would just leave everything as
it is, except document the issue.
Andrew
More information about the Linux-mediatek
mailing list