[PATCH v2 05/14] media: mediatek: vcodec: get different firmware ipi id

[Nicolas Dufresne]

Hi,

Le vendredi 15 août 2025 à 16:52 +0800, Yunfei Dong a écrit :
> Getting ipi(inter-processor interrupt) id according to firmware
> type and hardware index for different architecture.
> 
> Signed-off-by: Yunfei Dong <yunfei.dong at mediatek.com>
> ---
>  .../platform/mediatek/vcodec/common/mtk_vcodec_fw.c | 13 +++++++++++++
>  .../platform/mediatek/vcodec/common/mtk_vcodec_fw.h |  1 +
>  .../vcodec/decoder/vdec/vdec_av1_req_lat_if.c       |  4 ++--
>  .../vcodec/decoder/vdec/vdec_h264_req_multi_if.c    |  4 ++--
>  .../vcodec/decoder/vdec/vdec_hevc_req_multi_if.c    |  4 ++--
>  .../mediatek/vcodec/decoder/vdec/vdec_vp8_req_if.c  |  4 ++--
>  .../vcodec/decoder/vdec/vdec_vp9_req_lat_if.c       |  4 ++--
>  7 files changed, 24 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw.c b/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw.c
> index fc547afa4ebf..4ed7639dfa30 100644
> --- a/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw.c
> +++ b/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw.c
> @@ -5,6 +5,19 @@
>  #include "mtk_vcodec_fw_priv.h"
>  #include "mtk_vcodec_fw_vcp.h"
>  
> +int mtk_vcodec_fw_get_ipi(enum mtk_vcodec_fw_type type, int hw_id)
> +{
> +	switch (type) {
> +	case SCP:
> +		return hw_id == MTK_VDEC_LAT0 ? SCP_IPI_VDEC_LAT : SCP_IPI_VDEC_CORE;
> +	case VCP:
> +		return hw_id == MTK_VDEC_LAT0 ? VCP_IPI_LAT_DECODER : VCP_IPI_CORE_DECODER;
> +	default:
> +		return -EINVAL;
> +	}
> +}
> +EXPORT_SYMBOL_GPL(mtk_vcodec_fw_get_ipi);
> +
>  struct mtk_vcodec_fw *mtk_vcodec_fw_select(void *priv, enum mtk_vcodec_fw_type type,
>  					   enum mtk_vcodec_fw_use fw_use)
>  {
> diff --git a/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw.h b/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw.h
> index c1642fb09b42..142e2e87905c 100644
> --- a/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw.h
> +++ b/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw.h
> @@ -41,5 +41,6 @@ int mtk_vcodec_fw_ipi_register(struct mtk_vcodec_fw *fw, int id,
>  int mtk_vcodec_fw_ipi_send(struct mtk_vcodec_fw *fw, int id,
>  			   void *buf, unsigned int len, unsigned int wait);
>  int mtk_vcodec_fw_get_type(struct mtk_vcodec_fw *fw);
> +int mtk_vcodec_fw_get_ipi(enum mtk_vcodec_fw_type type, int hw_id);
>  
>  #endif /* _MTK_VCODEC_FW_H_ */
> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_av1_req_lat_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_av1_req_lat_if.c
> index bf21f2467a0f..618064001883 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_av1_req_lat_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_av1_req_lat_if.c
> @@ -1886,8 +1886,8 @@ static int vdec_av1_slice_init(struct mtk_vcodec_dec_ctx *ctx)
>  		return -ENOMEM;
>  
>  	instance->ctx = ctx;
> -	instance->vpu.id = SCP_IPI_VDEC_LAT;
> -	instance->vpu.core_id = SCP_IPI_VDEC_CORE;
> +	instance->vpu.id = mtk_vcodec_fw_get_ipi(ctx->dev->fw_handler->type, MTK_VDEC_LAT0);
> +	instance->vpu.core_id = mtk_vcodec_fw_get_ipi(ctx->dev->fw_handler->type, MTK_VDEC_CORE);

Now was a good time to use a local variable.

>  	instance->vpu.ctx = ctx;
>  	instance->vpu.codec_type = ctx->current_codec;
>  
> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_multi_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_multi_if.c
> index 5b25e1679b51..50f81f1cb616 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_multi_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_multi_if.c
> @@ -1212,8 +1212,8 @@ static int vdec_h264_slice_init(struct mtk_vcodec_dec_ctx *ctx)
>  
>  	inst->ctx = ctx;
>  
> -	inst->vpu.id = SCP_IPI_VDEC_LAT;
> -	inst->vpu.core_id = SCP_IPI_VDEC_CORE;
> +	inst->vpu.id = mtk_vcodec_fw_get_ipi(ctx->dev->fw_handler->type, MTK_VDEC_LAT0);
> +	inst->vpu.core_id = mtk_vcodec_fw_get_ipi(ctx->dev->fw_handler->type, MTK_VDEC_CORE);

Same and below.

>  	inst->vpu.ctx = ctx;
>  	inst->vpu.codec_type = ctx->current_codec;
>  	inst->vpu.capture_type = ctx->capture_fourcc;
> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_hevc_req_multi_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_hevc_req_multi_if.c
> index 2725db882e5b..80fbd0309b9e 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_hevc_req_multi_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_hevc_req_multi_if.c
> @@ -863,8 +863,8 @@ static int vdec_hevc_slice_init(struct mtk_vcodec_dec_ctx *ctx)
>  
>  	inst->ctx = ctx;
>  
> -	inst->vpu.id = SCP_IPI_VDEC_LAT;
> -	inst->vpu.core_id = SCP_IPI_VDEC_CORE;
> +	inst->vpu.id = mtk_vcodec_fw_get_ipi(ctx->dev->fw_handler->type, MTK_VDEC_LAT0);
> +	inst->vpu.core_id = mtk_vcodec_fw_get_ipi(ctx->dev->fw_handler->type, MTK_VDEC_CORE);
>  	inst->vpu.ctx = ctx;
>  	inst->vpu.codec_type = ctx->current_codec;
>  	inst->vpu.capture_type = ctx->capture_fourcc;
> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp8_req_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp8_req_if.c
> index 232ef3bd246a..764f4d4054c0 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp8_req_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp8_req_if.c
> @@ -281,8 +281,8 @@ static int vdec_vp8_slice_init(struct mtk_vcodec_dec_ctx *ctx)
>  
>  	inst->ctx = ctx;
>  
> -	inst->vpu.id = SCP_IPI_VDEC_LAT;
> -	inst->vpu.core_id = SCP_IPI_VDEC_CORE;
> +	inst->vpu.id = mtk_vcodec_fw_get_ipi(ctx->dev->fw_handler->type, MTK_VDEC_LAT0);
> +	inst->vpu.core_id = mtk_vcodec_fw_get_ipi(ctx->dev->fw_handler->type, MTK_VDEC_CORE);
>  	inst->vpu.ctx = ctx;
>  	inst->vpu.codec_type = ctx->current_codec;
>  	inst->vpu.capture_type = ctx->capture_fourcc;
> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c
> index 47c302745c1d..0279f66efdf9 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c
> @@ -1855,8 +1855,8 @@ static int vdec_vp9_slice_init(struct mtk_vcodec_dec_ctx *ctx)
>  		return -ENOMEM;
>  
>  	instance->ctx = ctx;
> -	instance->vpu.id = SCP_IPI_VDEC_LAT;
> -	instance->vpu.core_id = SCP_IPI_VDEC_CORE;
> +	instance->vpu.id = mtk_vcodec_fw_get_ipi(ctx->dev->fw_handler->type, MTK_VDEC_LAT0);
> +	instance->vpu.core_id = mtk_vcodec_fw_get_ipi(ctx->dev->fw_handler->type, MTK_VDEC_CORE);
>  	instance->vpu.ctx = ctx;
>  	instance->vpu.codec_type = ctx->current_codec;

regards,
Nicolas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-mediatek/attachments/20251128/6c7d0a73/attachment.sig>