[PATCH] arm64: dts: mediatek: mt8188-geralt: drop firmware-name from first SCP core

[Chen-Yu Tsai]

On Wed, Nov 19, 2025 at 4:31 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno at collabora.com> wrote:
>
> Il 19/11/25 08:02, Chen-Yu Tsai ha scritto:
> > Arnd pointed out that having firmware-name in the device tree is wrong.
> > Drop it.
> >
> > Fixes: e36be19823f0 ("arm64: dts: mediatek: mt8188-geralt: Enable first SCP core")
>
> Fixes here is .. well, right, but wrong - as if you "fix" that in previous kernel
> releases, you will create regressions :-)

This is a fix because the commit in question was merged in v6.18-rc1
and v6.18 hasn't been released yet. So you should pick it now for
v6.18.

> For all of the currently supported boards, I was planning to temporarily leave the
> firmware-name properties in place for one kernel version (v6.19) and remove it from
> all of them at once, for kernel v6.20.

OK. So I guess the plan is to have MT8188 SCP working in v6.18 based
on the current name then?

> I'd be okay if you send a commit or a series removing firmware-name from all of
> them, without any Fixes tag and without any "fix" word (so that we avoid autosel
> backports at all costs!), but keep in mind that I'd pick that in the next merge
> window, and not right now.

We can avoid autosel with:

     Cc: <stable+noautosel at kernel.org> # reason goes here, and must be present

(See stable-kernel-rules for the whole paragraph.)

After the blobs in the firmware repo have been renamed, we then explicitly
backport the change to stable. I think that works out better? And the only
one that needs to be timed is the MT8188 change anyway.

How does that sound?


ChenYu

> Thanks!
> Angelo
>
> > Signed-off-by: Chen-Yu Tsai <wenst at chromium.org>
> > ---
> >   arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi b/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi
> > index 7fedbacdac44..8e423504ec05 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi
> > @@ -1166,7 +1166,6 @@ &scp_cluster {
> >   &scp_c0 {
> >       pinctrl-names = "default";
> >       pinctrl-0 = <&scp_pins>;
> > -     firmware-name = "mediatek/mt8188/scp.img";
> >       memory-region = <&scp_mem_reserved>;
> >       status = "okay";
> >   };
>
>