[PATCH 1/1] pinctrl: airoha: fix pinctrl function mismatch issue
Christian Marangi
ansuelsmth at gmail.com
Sat Nov 15 11:54:52 PST 2025
On Sat, Nov 15, 2025 at 06:00:00PM +0800, Chukun Pan wrote:
> The blamed commit made the following changes:
>
> -#define PINCTRL_FUNC_DESC(id)...
> - .desc = PINCTRL_PINFUNCTION(#id, ...
> +#define PINCTRL_FUNC_DESC(id, table)...
> + .desc = PINCTRL_PINFUNCTION(#id, ...
>
> - PINCTRL_FUNC_DESC(pon)...
> + PINCTRL_FUNC_DESC("pon", pon)...
>
> It's clear that the id of funcs doesn't match the definition.
> Remove redundant #string from the definition to fix this issue:
> pinctrl-airoha ...: invalid function mdio in map table
>
> Fixes: 4043b0c45f85 ("pinctrl: airoha: generalize pins/group/function/confs handling")
> Signed-off-by: Chukun Pan <amadeus at jmu.edu.cn>
Acked-by: Christian Marangi <ansuelsmth at gmail.com>
> ---
> drivers/pinctrl/mediatek/pinctrl-airoha.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-airoha.c b/drivers/pinctrl/mediatek/pinctrl-airoha.c
> index bfcedc7f920b..18c952e44229 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-airoha.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-airoha.c
> @@ -35,7 +35,7 @@
>
> #define PINCTRL_FUNC_DESC(id, table) \
> { \
> - .desc = PINCTRL_PINFUNCTION(#id, table##_groups, \
> + .desc = PINCTRL_PINFUNCTION(id, table##_groups, \
> ARRAY_SIZE(table##_groups)),\
> .groups = table##_func_group, \
> .group_size = ARRAY_SIZE(table##_func_group), \
> --
> 2.25.1
>
--
Ansuel
More information about the Linux-mediatek
mailing list