[PATCH v1 05/10] media: mediatek: isp: Add the Imgsys LARBs device
Olivia Wen
olivia.wen at mediatek.com
Sat May 24 04:49:57 PDT 2025
The ImgSys driver is implemented as a series of patches, with this patch
focusing on the Imgsys LARBs device. This patch adds an independent
device driver for the ImgSys Local Arbiter (LARB) devices. The addition
is necessary because the IOMMU (Input/Output Memory Management Unit)
cannot support multiple LARBs within a single device node.
Signed-off-by: Olivia Wen <olivia.wen at mediatek.com>
---
.../isp/isp_7x/imgsys/mtk_imgsys-v4l2.c | 61 +++++++++++++++++++
1 file changed, 61 insertions(+)
diff --git a/drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-v4l2.c b/drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-v4l2.c
index cfd65858c751..919c69493bbc 100644
--- a/drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-v4l2.c
+++ b/drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-v4l2.c
@@ -28,6 +28,58 @@
#define IMGSYS_MAX_BUFFERS 256
#define IMGSYS_SUSPEND_TIME 3000 /* ms */
+struct mtk_imgsys_larb_device {
+ struct device *dev;
+ struct mtk_imgsys_dev *imgsys_dev;
+};
+
+static int mtk_imgsys_larb_probe(struct platform_device *pdev)
+{
+ struct device *dev = &pdev->dev;
+ struct mtk_imgsys_larb_device *larb_dev;
+
+ larb_dev = devm_kzalloc(dev, sizeof(*dev), GFP_KERNEL);
+ if (!larb_dev)
+ return -ENOMEM;
+
+ if (dma_set_mask_and_coherent(dev, DMA_BIT_MASK(34)))
+ dev_err(dev, "No suitable DMA available\n");
+
+ if (!dev->dma_parms) {
+ dev->dma_parms =
+ devm_kzalloc(dev, sizeof(*dev->dma_parms), GFP_KERNEL);
+ if (!dev->dma_parms)
+ return -ENOMEM;
+ }
+ if (pdev->dev.dma_parms)
+ dma_set_max_seg_size(dev, UINT_MAX);
+
+ pm_runtime_enable(dev);
+
+ return 0;
+}
+
+static void mtk_imgsys_larb_remove(struct platform_device *pdev)
+{
+ struct device *dev = &pdev->dev;
+
+ pm_runtime_disable(dev);
+}
+
+static const struct of_device_id mtk_imgsys_larb_match[] = {
+ {.compatible = "mediatek,mt8188-imgsys-larb",},
+ {},
+};
+
+static struct platform_driver mtk_imgsys_larb_driver = {
+ .probe = mtk_imgsys_larb_probe,
+ .remove = mtk_imgsys_larb_remove,
+ .driver = {
+ .name = "mtk-imgsys-larb",
+ .of_match_table = of_match_ptr(mtk_imgsys_larb_match),
+ },
+};
+
static int mtk_imgsys_sd_subscribe_event(struct v4l2_subdev *subdev,
struct v4l2_fh *fh,
struct v4l2_event_subscription *sub)
@@ -1537,8 +1589,16 @@ static int mtk_imgsys_probe(struct platform_device *pdev)
pm_runtime_use_autosuspend(&pdev->dev);
pm_runtime_enable(&pdev->dev);
+ ret = platform_driver_register(&mtk_imgsys_larb_driver);
+ if (ret) {
+ dev_info(imgsys_dev->dev, "register mtk_imgsys_larb_driver fail\n");
+ goto err_release_deinit_v4l2;
+ }
+
return 0;
+err_release_deinit_v4l2:
+ mtk_imgsys_dev_v4l2_release(imgsys_dev);
err_free_larb_alloc:
devm_kfree(&pdev->dev, imgsys_dev->larbs);
err_free_dev_alloc:
@@ -1551,6 +1611,7 @@ static void mtk_imgsys_remove(struct platform_device *pdev)
struct mtk_imgsys_dev *imgsys_dev = dev_get_drvdata(&pdev->dev);
pm_runtime_disable(&pdev->dev);
+ platform_driver_unregister(&mtk_imgsys_larb_driver);
mtk_imgsys_dev_v4l2_release(imgsys_dev);
devm_kfree(&pdev->dev, imgsys_dev->larbs);
devm_kfree(&pdev->dev, imgsys_dev);
--
2.45.2
More information about the Linux-mediatek
mailing list