[PATCH net-next 2/2] net: phy: mtk-ge-soc: Fix LED behavior if blinking is not set.
Sky Huang
SkyLake.Huang at mediatek.com
Fri May 23 04:36:01 PDT 2025
From: Sky Huang <skylake.huang at mediatek.com>
If delay_on==0 and delay_off==0 are passed to
mt798x_2p5ge_phy_led_blink_set() and mtk_phy_led_num_dly_cfg(),
blinking is actually not set. So don't clean "LED on" status under
this circumstance.
Signed-off-by: Sky Huang <skylake.huang at mediatek.com>
---
drivers/net/phy/mediatek/mtk-ge-soc.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/mediatek/mtk-ge-soc.c b/drivers/net/phy/mediatek/mtk-ge-soc.c
index cd0968478..15dcf2046 100644
--- a/drivers/net/phy/mediatek/mtk-ge-soc.c
+++ b/drivers/net/phy/mediatek/mtk-ge-soc.c
@@ -1228,8 +1228,11 @@ static int mt798x_phy_led_blink_set(struct phy_device *phydev, u8 index,
if (err)
return err;
- return mtk_phy_hw_led_on_set(phydev, index, MTK_GPHY_LED_ON_MASK,
- false);
+ if (blinking)
+ mtk_phy_hw_led_on_set(phydev, index, MTK_GPHY_LED_ON_MASK,
+ false);
+
+ return 0;
}
static int mt798x_phy_led_brightness_set(struct phy_device *phydev,
--
2.45.2
More information about the Linux-mediatek
mailing list