[PATCH 1/2] dt-bindings: regulator: mediatek: Add MT8196 vmm controller

[Krzysztof Kozlowski]

On 22/05/2025 17:09, Krzysztof Kozlowski wrote:
> On 22/05/2025 17:03, Nancy.Lin wrote:
>> From: Nancy Lin <nancy.lin at mediatek.com>
>>
>> Add a device tree binding document for the MediaTek MT8196 VMM (Vcore
>> for MultiMedia) regulator controller. The VMM controller acts as the
>> main power supplier for multimedia power domains, such as those used
>> by display, video encode and decode subsystems. It provides virtual
>> regulators that serve as the power sources for various multimedia IPs,
> 
> Virtual regulators do not sound real, so feels like you want some sort
> of power domains?
> 
> A nit, subject: drop second/last, redundant "bindings". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Wrong keyword... Please fix the subject prefixes:

For bindings, the preferred subjects are explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Best regards,
Krzysztof