[PATCH v2] ufs: core: Add HID support

Huan Tang tanghuan at vivo.com
Sun May 18 19:38:33 PDT 2025


Hi bart sir,

Thank you for your comments and guidance!
The v3 patch:
https://lore.kernel.org/all/20250519022912.292-1-tanghuan@vivo.com/

> All HID sysfs attributes occur in the "ufs_hid" directory and have a
> "hid_" prefix. That's two times "hid". Please remove the "hid_" prefix
> from the sysfs attribute names since it is redundant.
OK! It has been modified in the v3 patch.

> Isn't the prefix "ufs_" in "ufs_hid" redundant since this sysfs group
> occurs under a UFS host controller directory?
OK! It has been modified in the v3 patch.

> Regarding the name of this sysfs group, "ufs" occurs twice in that
> name (ufs_sysfs_ufs_hid_group). Please make sure that "ufs" only occurs
> once in that sysfs group name.
OK! It has been modified in the v3 patch.

> Please merge ufs_sysfs_ufs_hid_group into ufs_sysfs_groups, remove the
> new sysfs_create_group() call and add a visibility callback in
> ufs_sysfs_ufs_hid_group that only makes the attributes in this group
> visible if hba->dev_info.hid_sup == true.
OK! It has been modified in the v3 patch.

Thanks
Huan





More information about the Linux-mediatek mailing list