[PATCH v3 02/22] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API
Maxime Ripard
mripard at kernel.org
Sat May 10 01:43:04 PDT 2025
On Fri, May 09, 2025 at 03:53:28PM +0200, Luca Ceresoli wrote:
> devm_drm_bridge_alloc() is the new API to be used for allocating (and
> partially initializing) a private driver struct embedding a struct
> drm_bridge.
>
> For many drivers having a simple code flow in the probe function, this
> commit does a mass conversion automatically with the following semantic
> patch. The changes have been reviewed manually for correctness as well as
> to find any false positives.
>
> The patch has been applied with the explicit exclusion of bridge/panel.c,
> handled by a separate patch.
>
> After applying the semantic patch, manually fixed these issues:
>
> - 4 drivers need ERR_CAST() instead of PTR_ERR() as the function calling
> devm_drm_bridge_alloc() returns a pointer
> - re-added empty lines and comments that the script had removed but that
> should stay
>
> @@
> type T;
> identifier C;
> identifier BR;
> expression DEV;
> expression FUNCS;
> @@
> -T *C;
> +T *C;
> ...
> (
> -C = devm_kzalloc(DEV, ...);
> -if (!C)
> - return -ENOMEM;
> +C = devm_drm_bridge_alloc(DEV, T, BR, FUNCS);
> +if (IS_ERR(C))
> + return PTR_ERR(C);
> |
> -C = devm_kzalloc(DEV, ...);
> -if (!C)
> - return ERR_PTR(-ENOMEM);
> +C = devm_drm_bridge_alloc(DEV, T, BR, FUNCS);
> +if (IS_ERR(C))
> + return PTR_ERR(C);
> )
> ...
> -C->BR.funcs = FUNCS;
>
> Reviewed-by: Manikandan Muralidharan <manikandan.m at microchip.com> # microchip-lvds.c
> Reviewed-by: Douglas Anderson <dianders at chromium.org> # parade-ps8640
> Tested-by: Douglas Anderson <dianders at chromium.org> # parade-ps8640
> Signed-off-by: Luca Ceresoli <luca.ceresoli at bootlin.com>
Acked-by: Maxime Ripard <mripard at kernel.org>
Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 273 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-mediatek/attachments/20250510/486f32ac/attachment-0001.sig>
More information about the Linux-mediatek
mailing list