[PATCH v3] wifi: mt76: mt7925: fix missing hdr_trans_tlv command for broadcast wtbl

Niklas Schnelle niks at kernel.org
Fri May 9 02:40:36 PDT 2025


On Fri, 2025-05-09 at 09:04 +0800, Mingyen Hsieh wrote:
> From: Ming Yen Hsieh <mingyen.hsieh at mediatek.com>
> 
> Ensure that the hdr_trans_tlv command is included in the broadcast wtbl to
> prevent the IPv6 and multicast packet from being dropped by the chip.
> 
> Cc: stable at vger.kernel.org
> Fixes: cb1353ef3473 ("wifi: mt76: mt7925: integrate *mlo_sta_cmd and *sta_cmd")
> Reported-by: Benjamin Xiao <fossben at pm.me>
> Tested-by: Niklas Schnelle <niks at kernel.org>
> Link: https://lore.kernel.org/lkml/EmWnO5b-acRH1TXbGnkx41eJw654vmCR-8_xMBaPMwexCnfkvKCdlU5u19CGbaapJ3KRu-l3B-tSUhf8CCQwL0odjo6Cd5YG5lvNeB-vfdg=@pm.me/
> ---
> v2:
>     add tested-by tag
> v3:
>     add more info in commit
> ---
>  drivers/net/wireless/mediatek/mt76/mt7925/mcu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
> index a42b584634ab..fd756f0d18f8 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
> @@ -2183,14 +2183,14 @@ mt7925_mcu_sta_cmd(struct mt76_phy *phy,
>  			mt7925_mcu_sta_mld_tlv(skb, info->vif, info->link_sta->sta);
>  			mt7925_mcu_sta_eht_mld_tlv(skb, info->vif, info->link_sta->sta);
>  		}
> -
> -		mt7925_mcu_sta_hdr_trans_tlv(skb, info->vif, info->link_sta);
>  	}
>  
>  	if (!info->enable) {
>  		mt7925_mcu_sta_remove_tlv(skb);
>  		mt76_connac_mcu_add_tlv(skb, STA_REC_MLD_OFF,
>  					sizeof(struct tlv));
> +	} else {
> +		mt7925_mcu_sta_hdr_trans_tlv(skb, info->vif, info->link_sta);
>  	}
>  
>  	return mt76_mcu_skb_send_msg(dev, skb, info->cmd, true);

Thank you for picking up my suggestions so quickly! This looks much
better now.



More information about the Linux-mediatek mailing list