[PATCH v2] wifi: mt76: mt7925: fix missing hdr_trans_tlv command for broadcast wtbl

[Niklas Schnelle]

On Thu, 2025-05-08 at 16:55 +0800, Mingyen Hsieh wrote:
> From: Ming Yen Hsieh <mingyen.hsieh at mediatek.com>
> 
> The hdr_trans_tlv function call has been moved inside the conditional block
> to ensure it is executed when info->enable is true.
> 
> Cc: stable at vger.kernel.org
> Fixes: cb1353ef3473 ("wifi: mt76: mt7925: integrate *mlo_sta_cmd and *sta_cmd")
> Signed-off-by: Ming Yen Hsieh <mingyen.hsieh at mediatek.com>
> Tested-by: Niklas Schnelle <niks at kernel.org>
> ---
> v2:
>     add tested-by tag
> 

Thanks for adding the tag, appreciate it. If I may add some stylistic
comments. I saw that this is one of your first independent upstream
patches so congratulations on that and even better it's an actual
proper fix. Well done!

One thing, I noticed though is that your commit message lacks context,
like this affecting IPv6 and multicast. Basically it just re-iterates
what I can already see in the code. It also doesn't use the recommended
imperative tone (see [0]). Moreover, I think this would be a good case
for using a Link: tag pointing to the thread[1] of Ben's bisect result.
Relatedly one could also add a Reported-by tag for Ben, I still fondly
remember getting a Reported-by mention long before I did my first
kernel contribution. This stuff is hard to balance with getting fixes
out there and I still screw up some detail with mails sometimes, but
we're all learning so wanted to give my 5 cents.

Thanks,
Niklas

[0]
https://www.kernel.org/doc/html/v4.12/process/submitting-patches.html#describe-your-changes
[1]
https://lore.kernel.org/lkml/EmWnO5b-acRH1TXbGnkx41eJw654vmCR-8_xMBaPMwexCnfkvKCdlU5u19CGbaapJ3KRu-l3B-tSUhf8CCQwL0odjo6Cd5YG5lvNeB-vfdg=@pm.me/

> ---
>  drivers/net/wireless/mediatek/mt76/mt7925/mcu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
> index a42b584634ab..fd756f0d18f8 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
> @@ -2183,14 +2183,14 @@ mt7925_mcu_sta_cmd(struct mt76_phy *phy,
>  			mt7925_mcu_sta_mld_tlv(skb, info->vif, info->link_sta->sta);
>  			mt7925_mcu_sta_eht_mld_tlv(skb, info->vif, info->link_sta->sta);
>  		}
> -
> -		mt7925_mcu_sta_hdr_trans_tlv(skb, info->vif, info->link_sta);
>  	}
>  
>  	if (!info->enable) {
>  		mt7925_mcu_sta_remove_tlv(skb);
>  		mt76_connac_mcu_add_tlv(skb, STA_REC_MLD_OFF,
>  					sizeof(struct tlv));
> +	} else {
> +		mt7925_mcu_sta_hdr_trans_tlv(skb, info->vif, info->link_sta);
>  	}
>  
>  	return mt76_mcu_skb_send_msg(dev, skb, info->cmd, true);