[PATCH v10 RESEND] wifi: mt76: mt7915: add wds support when wed is enabled
Felix Fietkau
nbd at nbd.name
Wed Jun 25 03:18:07 PDT 2025
On 24.06.25 16:11, Shengyu Qu wrote:
> Hi Felix,
>
> Please, tell me if this patch needs any polishing. I really don't know
> why this patch still not get merged after such a long time(and 2x
> resend), especially it already got a Reviewed-by and is a bugfix.
Hi Shengyu,
sorry it took such a long time for me to take a look at this patch.
I don't see how it can even work properly in its current form, because
of at least one bug:
When switching from non-wds to wds mode, the code calls
mt7915_mac_sta_add in order to create the new sta. However, after
changes that I made a while back, this function does not actually upload
the station to the MCU anymore, since it is called on the NOTEXIST->NONE
transition before assoc. Without corresponding ASSOC/AUTHORIZE events
(handled by mt7915_mac_sta_event), the firmware doesn't get any data for
the new wcid.
That said, I finally got around to starting to rework your patch myself.
I will let you know when I have something ready for testing, hopefully
later today.
- Felix
More information about the Linux-mediatek
mailing list