[PATCH v3 1/3] iommu: omap: Drop redundant check if ti,syscon-mmuconfig exists
Robin Murphy
robin.murphy at arm.com
Tue Jun 24 10:15:21 PDT 2025
On 2025-06-24 1:22 pm, Krzysztof Kozlowski wrote:
> The syscon_regmap_lookup_by_phandle() will fail if property does not
> exist, so doing of_property_read_bool() earlier is redundant. Drop that
> check and move error message to syscon_regmap_lookup_by_phandle() error
> case while converting it to dev_err_probe().
Sure, may as well.
Reviewed-by: Robin Murphy <robin.murphy at arm.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> ---
> drivers/iommu/omap-iommu.c | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
> index 3c62337f43c67720a15b67e8b610da7886f6f39c..4448c0a512137c79195112eea25d762266c77bc3 100644
> --- a/drivers/iommu/omap-iommu.c
> +++ b/drivers/iommu/omap-iommu.c
> @@ -1123,23 +1123,15 @@ static int omap_iommu_dra7_get_dsp_system_cfg(struct platform_device *pdev,
> struct omap_iommu *obj)
> {
> struct device_node *np = pdev->dev.of_node;
> - int ret;
>
> if (!of_device_is_compatible(np, "ti,dra7-dsp-iommu"))
> return 0;
>
> - if (!of_property_read_bool(np, "ti,syscon-mmuconfig")) {
> - dev_err(&pdev->dev, "ti,syscon-mmuconfig property is missing\n");
> - return -EINVAL;
> - }
> -
> obj->syscfg =
> syscon_regmap_lookup_by_phandle(np, "ti,syscon-mmuconfig");
> - if (IS_ERR(obj->syscfg)) {
> - /* can fail with -EPROBE_DEFER */
> - ret = PTR_ERR(obj->syscfg);
> - return ret;
> - }
> + if (IS_ERR(obj->syscfg))
> + return dev_err_probe(&pdev->dev, PTR_ERR(obj->syscfg),
> + "ti,syscon-mmuconfig property is missing\n");
>
> if (of_property_read_u32_index(np, "ti,syscon-mmuconfig", 1,
> &obj->id)) {
>
More information about the Linux-mediatek
mailing list