[PATCH] dmaengine: mediatek: Fix a flag reuse error in mtk_cqdma_tx_status()
Eugen Hristev
eugen.hristev at linaro.org
Fri Jun 6 03:00:14 PDT 2025
On 6/6/25 12:14, Qiu-ji Chen wrote:
>> On 6/6/25 10:17, Qiu-ji Chen wrote:
>>> Fixed a flag reuse bug in the mtk_cqdma_tx_status() function.
>> If the first spin_lock_irqsave already saved the irq flags and disabled
>> them, would it be meaningful to actually use a simple spin_lock for the
>> second lock ? Or rather spin_lock_nested since there is a second nested
>> lock taken ?
>>
>> Eugen
>>
>
> Hello Eugen,
>
> Thanks for helpful suggestion. The modification has been submitted in
> patch v2 as discussed.
>
> Best regards,
> Qiu-ji Chen
You are welcome, but in fact I suggested two alternatives. Any reason
you picked this one instead of the other ?
More information about the Linux-mediatek
mailing list