[PATCH v1 1/8] dt-bindings: media: mediatek: decoder: Add MT8189 mediatek,vcodec-decoder

Krzysztof Kozlowski krzk at kernel.org
Tue Jul 22 04:09:47 PDT 2025


On 22/07/2025 10:11, Kyrie Wu (吴晗) wrote:
> On Tue, 2025-07-22 at 09:25 +0200, Krzysztof Kozlowski wrote:
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>
>>
>> On Mon, Jul 21, 2025 at 06:55:13PM +0800, Kyrie Wu wrote:
>>> Add compatible for video decoder on MT8189 platform, which is a
>>> pure single core architecture.
>>
>> Looks compatible with existing ones and nothing in commit msg
>> explains
>> why it was not made compatible. Describe the hardware, say something
>> useful to avoid such questions.
>>
>> Best regards,
>> Krzysztof
>>
> Dear Krzysztof,
> 
> There are two reasons for adding a new compatible string to MT8189:
> On the one hand, MT8189 is a pure single-core hardware chip, so the
> of_device_id data is different;

Not relevant. Your of_device_id is wrong and based on that you claim the
hardware is different?

Describe the hardware.

Best regards,
Krzysztof



More information about the Linux-mediatek mailing list