[PATCH v1 08/10] ufs: host: mediatek: Add clock scaling query function
kernel test robot
lkp at intel.com
Wed Jul 16 22:16:06 PDT 2025
Hi,
kernel test robot noticed the following build warnings:
[auto build test WARNING on jejb-scsi/for-next]
[also build test WARNING on mkp-scsi/for-next linus/master v6.16-rc6 next-20250716]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/peter-wang-mediatek-com/ufs-host-mediatek-Change-return-type-to-bool/20250716-184239
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
patch link: https://lore.kernel.org/r/20250716062830.3712487-9-peter.wang%40mediatek.com
patch subject: [PATCH v1 08/10] ufs: host: mediatek: Add clock scaling query function
config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20250717/202507171210.1ZvrCG7u-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250717/202507171210.1ZvrCG7u-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507171210.1ZvrCG7u-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/ufs/host/ufs-mediatek.c: In function 'ufs_mtk_init_clocks':
>> drivers/ufs/host/ufs-mediatek.c:941:29: warning: unused variable 'mclk' [-Wunused-variable]
941 | struct ufs_mtk_clk *mclk = &host->mclk;
| ^~~~
vim +/mclk +941 drivers/ufs/host/ufs-mediatek.c
2c89e41326b16e drivers/scsi/ufs/ufs-mediatek.c Stanley Chu 2021-05-31 931
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 932 /**
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 933 * ufs_mtk_init_clocks - Init mtk driver private clocks
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 934 *
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 935 * @hba: per adapter instance
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 936 */
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 937 static void ufs_mtk_init_clocks(struct ufs_hba *hba)
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 938 {
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 939 struct ufs_mtk_host *host = ufshcd_get_variant(hba);
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 940 struct list_head *head = &hba->clk_list_head;
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 @941 struct ufs_mtk_clk *mclk = &host->mclk;
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 942 struct ufs_clk_info *clki, *clki_tmp;
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 943
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 944 /*
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 945 * Find private clocks and store them in struct ufs_mtk_clk.
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 946 * Remove "ufs_sel_min_src" and "ufs_sel_min_src" from list to avoid
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 947 * being switched on/off in clock gating.
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 948 */
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 949 list_for_each_entry_safe(clki, clki_tmp, head, list) {
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 950 if (!strcmp(clki->name, "ufs_sel")) {
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 951 host->mclk.ufs_sel_clki = clki;
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 952 } else if (!strcmp(clki->name, "ufs_sel_max_src")) {
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 953 host->mclk.ufs_sel_max_clki = clki;
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 954 clk_disable_unprepare(clki->clk);
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 955 list_del(&clki->list);
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 956 } else if (!strcmp(clki->name, "ufs_sel_min_src")) {
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 957 host->mclk.ufs_sel_min_clki = clki;
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 958 clk_disable_unprepare(clki->clk);
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 959 list_del(&clki->list);
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 960 }
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 961 }
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 962
37e94f8b8c2c07 drivers/ufs/host/ufs-mediatek.c Peter Wang 2025-07-16 963 if (!ufs_mtk_is_clk_scale_ready(hba)) {
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 964 hba->caps &= ~UFSHCD_CAP_CLK_SCALING;
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 965 dev_info(hba->dev,
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 966 "%s: Clk-scaling not ready. Feature disabled.",
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 967 __func__);
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 968 }
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 969 }
b7dbc686f60b28 drivers/ufs/host/ufs-mediatek.c Po-Wen Kao 2022-08-03 970
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
More information about the Linux-mediatek
mailing list