[PATCH net-next v2 2/7] net: airoha: npu: Add NPU wlan memory initialization commands

Lorenzo Bianconi lorenzo at kernel.org
Mon Jul 14 03:09:25 PDT 2025


> On 08/07/2025 09:33, Lorenzo Bianconi wrote:
> > 
> >>
> >>> posted net-next patches as preliminary ones for MT76 changes).
> >>> Moreover, this is the same approach we used when we added WED support to
> >>> mtk_eth_soc driver and the related MT76 support.
> >>> However, I am fine to post the MT76 changes as RFC and just refer to it in
> >>> this series cover-letter. Agree? 
> >>>
> >>>>
> >>>> So far I see ABI break, but without user cannot judge. And that's the
> >>>> hard reason this cannot be accepted.
> >>>
> >>> if you mean the dts changes, I will fix them in v3.
> >>>
> >> No, I mean driver.
> > 
> > Sorry, can you please explain what is the ABI break in the driver codebase?
> > airoha_npu_wlan_init_memory() is executed by MT76 driver and not during NPU
> > probe phase.
> > 
> 
> Read the first problem I pointed out - no user. Your new ABI returns
> error and you changed binding in incompatible way.
> 
> Binding change is ABI break and its impact is impossible to judge due to
> missing code. I am speaking about this since beginning, but if you keep
> insisting that the driver does not matter then this is a NAK because you
> change ABI in the binding.

Please do not get me wrong, I was just trying to understand where the ABI
breakage is. I will post my MT76 changes as RFC and I will link that series
in the v3 cover letter so you can look at the new API user code.

Regards,
Lorenzo

> 
> 
> Best regards,
> Krzysztof
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-mediatek/attachments/20250714/684f4bde/attachment.sig>


More information about the Linux-mediatek mailing list