[PATCH v2 1/2] dt-bindings: dsp: mediatek: add mt8196 dsp document

Krzysztof Kozlowski krzk at kernel.org
Thu Jul 3 03:24:38 PDT 2025


On 03/07/2025 11:05, AngeloGioacchino Del Regno wrote:
>>> +
>>> +  clocks:
>>> +    items:
>>> +      - description: mux for dsp clock
>>> +      - description: 26M clock
>>> +      - description: ADSP PLL clock
>>> +
>>> +  clock-names:
>>> +    items:
>>> +      - const: adsp_sel
>>
>> Isn't this called audiodsp in other bindings?
>>
>>> +      - const: clk26m
>>
>> Don't use frequencies. How is the pin or input called in datasheet? How
>> other devices call it?
> 
> In the datasheet, this is called.... CLK26M (really).
> 
OK, this is a valid argument, however we still try to unify the inputs
so bindings can share such pieces. It is discouraged to have similar
devices with different bindings in only one place: clk26m -> clk27m or
whatever other number.

Common is also to name the clock input based on the purpose (like bus, ref).


Best regards,
Krzysztof



More information about the Linux-mediatek mailing list