[PATCH net-next v2 4/5] net: phylink: use neg_mode in phylink_mii_c22_pcs_decode_state()
Russell King (Oracle)
rmk+kernel at armlinux.org.uk
Mon Jan 13 01:22:39 PST 2025
Rather than using the state of the Autoneg bit, which is unreliable
with the new PCS neg mode support, use the passed neg_mode to decide
whether to decode the link partner advertisement data.
Signed-off-by: Russell King (Oracle) <rmk+kernel at armlinux.org.uk>
---
drivers/net/phy/phylink.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index b29b7e73b5bd..b79f975bc164 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -3877,11 +3877,15 @@ void phylink_mii_c22_pcs_decode_state(struct phylink_link_state *state,
{
state->link = !!(bmsr & BMSR_LSTATUS);
state->an_complete = !!(bmsr & BMSR_ANEGCOMPLETE);
- /* If there is no link or autonegotiation is disabled, the LP advertisement
- * data is not meaningful, so don't go any further.
+
+ /* If the link is down, the advertisement data is undefined. */
+ if (!state->link)
+ return;
+
+ /* If in-band is disabled, then the advertisement data is not
+ * meaningful.
*/
- if (!state->link || !linkmode_test_bit(ETHTOOL_LINK_MODE_Autoneg_BIT,
- state->advertising))
+ if (neg_mode != PHYLINK_PCS_NEG_INBAND_ENABLED)
return;
switch (state->interface) {
--
2.30.2
More information about the Linux-mediatek
mailing list