Re: [PATCH net-next 3/6] net: pcs: mtk-lynxi: fill in PCS supported_interfaces

[Daniel Golle]

On 3 January 2025 11:16:41 UTC, "Russell King (Oracle)" <rmk+kernel at armlinux.org.uk> wrote:
>Fill in the new PCS supported_interfaces member with the interfaces
>that the Mediatek LynxI supports.
>
>Signed-off-by: Russell King (Oracle) <rmk+kernel at armlinux.org.uk>

Acked-by: Daniel Golle <daniel at makrotopia.org>

>---
> drivers/net/pcs/pcs-mtk-lynxi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/drivers/net/pcs/pcs-mtk-lynxi.c b/drivers/net/pcs/pcs-mtk-lynxi.c
>index 7de804535229..a6153e9999a7 100644
>--- a/drivers/net/pcs/pcs-mtk-lynxi.c
>+++ b/drivers/net/pcs/pcs-mtk-lynxi.c
>@@ -306,6 +306,10 @@ struct phylink_pcs *mtk_pcs_lynxi_create(struct device *dev,
> 	mpcs->pcs.poll = true;
> 	mpcs->interface = PHY_INTERFACE_MODE_NA;
> 
>+	__set_bit(PHY_INTERFACE_MODE_SGMII, mpcs->pcs.supported_interfaces);
>+	__set_bit(PHY_INTERFACE_MODE_1000BASEX, mpcs->pcs.supported_interfaces);
>+	__set_bit(PHY_INTERFACE_MODE_2500BASEX, mpcs->pcs.supported_interfaces);
>+
> 	return &mpcs->pcs;
> }
> EXPORT_SYMBOL(mtk_pcs_lynxi_create);