[PATCH v3] ufs: core: add hba parameter to trace events

Bean Huo huobean at gmail.com
Sun Feb 16 06:15:33 PST 2025


On Fri, 2025-02-14 at 16:29 +0800, peter.wang at mediatek.com wrote:
> From: Peter Wang <peter.wang at mediatek.com>
> 
> Included the ufs_hba structure as a parameter in various trace events
> to provide more context and improve debugging capabilities.


>From the patch commit message, it is no clear how you can use this
change to get more infor and debug, since the content of the ftrace
output is the same after this change. Because the device name
(dev_name) is still being printed, but now it is derived dynamically
from hba->dev instead of being stored as a string in the trace event. 

I assume you mean to let bpf get more information from hba:


strust ufs hba *hba = ctx->hba;

If my assumption is correct, this purpose and intent should be
prominently highlighted in patch commit message.


Kind regards,
Bean



More information about the Linux-mediatek mailing list