[PATCH 4/5] arm64: dts: mediatek: add device tree for Tungsten 510 board

[Krzysztof Kozlowski]

On 01/12/2025 09:41, Gary Bisson wrote:
> +
> +&i2c_mux_lcd_2 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +
> +	bridge at 2c {
> +		compatible = "ti,sn65dsi84";
> +		reg = <0x2c>;
> +		enable-gpios = <&pio 25 GPIO_ACTIVE_HIGH>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&dsi0_sn65dsi84_pins>;
> +		status = "okay";

Did you disable it anywhere?


...


> +
> +&spmi {
> +	#address-cells = <1>;
> +	#size-cells = <2>;
> +
> +	mt6315_6: mt6315 at 6 {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
If you cannot find a name matching your device, please check in kernel
sources for similar cases or you can grow the spec (via pull request to
DT spec repo).

e.g. pmic

> +		compatible = "mediatek,mt6315-regulator";
> +		reg = <0x6 0 0xb>;



Best regards,
Krzysztof