[PATCH net-next 2/3] net: airoha: Add airoha_ppe_dev struct definition
Jakub Kicinski
kuba at kernel.org
Fri Aug 22 07:04:40 PDT 2025
On Fri, 22 Aug 2025 08:58:25 +0200 Lorenzo Bianconi wrote:
> > On Tue, 19 Aug 2025 14:21:07 +0200 Lorenzo Bianconi wrote:
> > > + pdev = of_find_device_by_node(np);
> > > +
> >
> > did you mean to put the of_node_put() here?
> >
> > > + if (!pdev) {
> > > + dev_err(dev, "cannot find device node %s\n", np->name);
> > > + of_node_put(np);
> > > + return ERR_PTR(-ENODEV);
> > > + }
> > > + of_node_put(np);
>
> I moved the of_node_put() here (and in the if branch) in order to fix a similar
> issue fixed by Alok for airoha_npu.
Ah, didn't notice it in the print..
maybe remove the empty line between the of_find_device.. and the null
check on pdev then?
More information about the Linux-mediatek
mailing list