[PATCH net] net: airoha: ppe: Do not invalid PPE entries in case of SW hash collision
patchwork-bot+netdevbpf at kernel.org
patchwork-bot+netdevbpf at kernel.org
Thu Aug 21 02:40:06 PDT 2025
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni at redhat.com>:
On Mon, 18 Aug 2025 11:58:25 +0200 you wrote:
> SW hash computed by airoha_ppe_foe_get_entry_hash routine (used for
> foe_flow hlist) can theoretically produce collisions between two
> different HW PPE entries.
> In airoha_ppe_foe_insert_entry() if the collision occurs we will mark
> the second PPE entry in the list as stale (setting the hw hash to 0xffff).
> Stale entries are no more updated in airoha_ppe_foe_flow_entry_update
> routine and so they are removed by Netfilter.
> Fix the problem not marking the second entry as stale in
> airoha_ppe_foe_insert_entry routine if we have already inserted the
> brand new entry in the PPE table and let Netfilter remove real stale
> entries according to their timestamp.
> Please note this is just a theoretical issue spotted reviewing the code
> and not faced running the system.
>
> [...]
Here is the summary with links:
- [net] net: airoha: ppe: Do not invalid PPE entries in case of SW hash collision
https://git.kernel.org/netdev/net/c/9f6b606b6b37
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
More information about the Linux-mediatek
mailing list