[PATCH v2 1/6] dt-bindings: clock: mediatek: Add power-domains property
Julien Massot
julien.massot at collabora.com
Thu Aug 21 01:38:46 PDT 2025
Hi Krzysztof,
Thanks for the review
On Thu, 2025-08-21 at 09:30 +0200, Krzysztof Kozlowski wrote:
> On 21/08/2025 09:16, Krzysztof Kozlowski wrote:
> > On Wed, Aug 20, 2025 at 03:44:52PM +0200, Julien Massot wrote:
> > > The mt8183-mfgcfg node uses a power domain in its device tree node.
> > > To prevent schema validation warnings, add the optional `power-domains`
> > > property to the binding schema for mediatek syscon clocks.
> > >
> > > Fixes: 1781f2c46180 ("arm64: dts: mediatek: mt8183: Add power-domains property to mfgcfg")
> >
> > Checkpatch complains here, but more important - where is explanation of
> > dropped tag?
Right the proper tag is
Fixes: 1781f2c46180 ("arm64: dts: mediatek: mt8183: Add power-domains properity to mfgcfg")
> >
> > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno at collabora.com>
> >
> > But this tag appeared? It wasn't even given!
> >
> > You remove public tags and add tags never given on the lists.
>
> I found Angelo's tag, but still dropping other acks is not explained.
>
Regarding the tags: in v2 the patch changed quite a lot after I applied
Angelo's suggestion, so I decided to drop Rob’s Acked-by as it no longer
applies to the new version. I should have explained this in the changelog.
Regards,
Julien
More information about the Linux-mediatek
mailing list