[PATCH 2/2] net: ethernet: mtk-star-emac: rearm interrupts in rx_poll only when advised

Maxime Chevallier maxime.chevallier at bootlin.com
Tue Apr 22 07:07:16 PDT 2025


Hi Louis-Alexis,

On Tue, 22 Apr 2025 15:03:39 +0200
Louis-Alexis Eyraud <louisalexis.eyraud at collabora.com> wrote:

> In mtk_star_rx_poll function, on event processing completion, the
> mtk_star_emac driver calls napi_complete_done but ignores its return
> code and enable RX DMA interrupts inconditionally. This return code
> gives the info if a device should avoid rearming its interrupts or not,
> so fix this behaviour by taking it into account.
> 
> Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud at collabora.com>

Patch looks correct, however is it fixing a problematic behaviour
you've seen ? I'm asking because it lacks a Fixes: tag, as well as
targetting one of the net/net-next trees :)

Thanks,

Maxime




More information about the Linux-mediatek mailing list