[v1,1/1] i2c: mediatek: add runtime PM operations and bus regulator control

[Andi Shyti]

Hi,

...

> > @@ -1486,19 +1530,22 @@ static int mtk_i2c_probe(struct platform_device *pdev)
> >   	if (ret < 0) {
> >   		dev_err(&pdev->dev,
> >   			"Request I2C IRQ %d fail\n", irq);
> > -		goto err_bulk_unprepare;
> > +		goto err_clk_bulk_unprepare;
> >   	}
> > +	pm_runtime_set_autosuspend_delay(&pdev->dev, 1000);
> 
> One full second as autosuspend delay? Can this be shortened to 500? 250?
> 
> How was the one second wait chosen?
> 
> How much time does mtk_i2c_runtime_resume() take to resume the bus?

Besides that, please add a comment to explain why you chose
1000/500/250. Arbitrary values are not much appreciated.

Thanks,
Andi