[PATCH v8 1/5] ASoC: codecs: add MT6357 support

[Geert Uytterhoeven]

Hi Alexandre,

On Thu, Sep 5, 2024 at 11:08 AM <amergnat at baylibre.com> wrote:
> From: Nicolas Belin <nbelin at baylibre.com>
>
> Add the support of MT6357 PMIC audio codec.
>
> Signed-off-by: Nicolas Belin <nbelin at baylibre.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno at collabora.com>
> Signed-off-by: Alexandre Mergnat <amergnat at baylibre.com>

Thanks for your patch, which is now commit 5e2404493f9f6028 ("ASoC:
codecs: add MT6357 support").

> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -2501,6 +2502,12 @@ config SND_SOC_ML26124
>  config SND_SOC_MT6351
>         tristate "MediaTek MT6351 Codec"
>
> +config SND_SOC_MT6357
> +       tristate "MediaTek MT6357 Codec"

Does this need dependencies?  The driver uses regmap, but it's not
immediately clear to me what is the backend (SPI?).

SND_SOC_MT6357 is selected by SND_SOC_MT8365_MT6357 in the next patch,
but I guess there can be other users, so making the SND_SOC_MT6357
symbol invisible ("tristate ... if COMPILE_TEST") is not an option?

Similar comments for the pre-existing SND_SOC_MT635[189] symbols,
but at least SND_SOC_MT6359 depends on MTK_PMIC_WRAP.

> +       help
> +         Enable support for the platform which uses MT6357 as
> +         external codec device.
> +
>  config SND_SOC_MT6358
>         tristate "MediaTek MT6358 Codec"
>         help

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds