[PATCH v2 1/2] ufs: core: fix the issue of ICU failure

[Peter Wang (王信友)]

On Fri, 2024-09-06 at 13:39 -0700, Bao D. Nguyen wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On 9/1/2024 7:18 PM, peter.wang at mediatek.com wrote:
> 
> >   /* SQRTCy.ICU = 1 */
> > -writel(SQ_ICU, opr_sqd_base + REG_SQRTC);
> > +writel(readl(opr_sqd_base + REG_SQRTC) | SQ_ICU,
> > +opr_sqd_base + REG_SQRTC);
> Hi Peter,
> Instead of readl() here, how about write (SQ_STOP | SQ_ICU) to SQRTC?
> 
> Thanks, Bao

Hi Bao,

My opinion is not to do it this way, because we don't know if 
the future specification of REG_SQRTC will add extra bits. 
Once added, such an approach would again become a bug in ufs driver.

Thanks
Peter