[PATCH -next] pmdomain: mediatek: make use of dev_err_cast_probe()

Matthias Brugger matthias.bgg at gmail.com
Mon Sep 2 04:12:04 PDT 2024



On 28/08/2024 14:12, Hongbo Li wrote:
> Using dev_err_cast_probe() to simplify the code.
> 
> Signed-off-by: Hongbo Li <lihongbo22 at huawei.com>

Reviewed-by: Matthias Brugger <matthias.bgg at gmail.com>

> ---
>   drivers/pmdomain/mediatek/mtk-pm-domains.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pmdomain/mediatek/mtk-pm-domains.c b/drivers/pmdomain/mediatek/mtk-pm-domains.c
> index e274e3315fe7..88406e9ac63c 100644
> --- a/drivers/pmdomain/mediatek/mtk-pm-domains.c
> +++ b/drivers/pmdomain/mediatek/mtk-pm-domains.c
> @@ -398,12 +398,10 @@ generic_pm_domain *scpsys_add_one_domain(struct scpsys *scpsys, struct device_no
>   		scpsys->dev->of_node = node;
>   		pd->supply = devm_regulator_get(scpsys->dev, "domain");
>   		scpsys->dev->of_node = root_node;
> -		if (IS_ERR(pd->supply)) {
> -			dev_err_probe(scpsys->dev, PTR_ERR(pd->supply),
> +		if (IS_ERR(pd->supply))
> +			return dev_err_cast_probe(scpsys->dev, pd->supply,
>   				      "%pOF: failed to get power supply.\n",
>   				      node);
> -			return ERR_CAST(pd->supply);
> -		}
>   	}
>   
>   	pd->infracfg = syscon_regmap_lookup_by_phandle_optional(node, "mediatek,infracfg");



More information about the Linux-mediatek mailing list