[PATCH 3/3] drivers: core: fw_devlink: Make the error message a bit more useful
Saravana Kannan
saravanak at google.com
Wed Oct 23 23:13:44 PDT 2024
It would make it easier to debugs issues similar to the ones
reported[1][2] recently where some devices didn't have the fwnode set.
[1] - https://lore.kernel.org/all/7b995947-4540-4b17-872e-e107adca4598@notapiano/
[2] - https://lore.kernel.org/all/20240910130019.35081-1-jonathanh@nvidia.com/
Signed-off-by: Saravana Kannan <saravanak at google.com>
---
drivers/base/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index a4c853411a6b..3b13fed1c3e3 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -2181,8 +2181,8 @@ static int fw_devlink_create_devlink(struct device *con,
}
if (con != sup_dev && !device_link_add(con, sup_dev, flags)) {
- dev_err(con, "Failed to create device link (0x%x) with %s\n",
- flags, dev_name(sup_dev));
+ dev_err(con, "Failed to create device link (0x%x) with supplier %s for %pfwf\n",
+ flags, dev_name(sup_dev), link->consumer);
ret = -EINVAL;
}
--
2.47.0.105.g07ac214952-goog
More information about the Linux-mediatek
mailing list