[PATCH v1] ufs: core: fix another deadlock when rtc update

Peter Wang (王信友) peter.wang at mediatek.com
Wed Oct 23 18:53:02 PDT 2024


On Wed, 2024-10-23 at 12:34 -0700, Bart Van Assche wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  
> On 10/23/24 6:19 AM, peter.wang at mediatek.com wrote:
> > From: Peter Wang <peter.wang at mediatek.com>
> > 
> > When ufshcd_rtc_work calls ufshcd_rpm_put_sync and the pm's
> > usage_count is 0, it will enter the runtime suspend callback.
> > However, the runtime suspend callback will wait to flush
> > ufshcd_rtc_work, causing a deadlock.
> > Replacing ufshcd_rpm_put_sync with ufshcd_rpm_put can avoid
> > the deadlock.
> > 
> > Fixes: 6bf999e0eb41 ("scsi: ufs: core: Add UFS RTC support")
> > Cc: <stable at vger.kernel.org> 6.11.x
> > 
> > Signed-off-by: Peter Wang <peter.wang at mediatek.com>
> 
> No blank lines in the tags section please. Additionally, a hash sign
> (#) is missing between "<stable at vger.kernel.org>" and "6.11.x".
> Otherwise this patch looks good to me. Hence:
> 
> Reviewed-by: Bart Van Assche <bvanassche at acm.org>

Hi Bart,

I will update commit message next version.

Thanks
Peter


More information about the Linux-mediatek mailing list