[PATCH net-next 1/1] net: phy: Refactor mediatek-ge-soc.c for clarity and correctness

SkyLake Huang (黃啟澤) SkyLake.Huang at mediatek.com
Wed Oct 16 09:25:14 PDT 2024


> I do think that would be best.
> But if you strongly think otherwise I can try to review it as-is.

Hi Simon,
  If this does cause trouble for reviewing, I can split it into a few
patches:
Patch 1: Fix spelling errors + reverse Xmas tree + remove unnecessary
parens
Patch 2: Shrink mtk-ge-soc.c line wrapping to 80 characters.
Patch 3: Propagate error code correctly in cal_cycle() + FIELD_GET()
change
Patch 4: Fix multi functions with FIELD_PREP().

  Is this okay for you? Do I need to split them into more patches?

BRs,
Sky


More information about the Linux-mediatek mailing list