[PATCH net-next] net: airoha: Fix EGRESS_RATE_METER_EN_MASK definition

[Jacob Keller]

On 10/5/2024 3:24 AM, Lorenzo Bianconi wrote:
>>
>>
>> On 10/4/2024 2:51 PM, Lorenzo Bianconi wrote:
>>> Fix typo in EGRESS_RATE_METER_EN_MASK mask definition. This bus was not
>>> introducing any user visible problem.
>>>
>>
>> I'm not sure I follow. This bit is used by airoha_qdma_init_qos which
>> sets the REG_EGRESS_RATE_METER_CFG register?
>>
>> How does this not provide any user visible issues? It seems like an
>> incorrect enable bit likely means that QOS is not enabled? I'm guessing
>> bit 29 is reserved?
> 
> Hi Jacob,
> 
> even if we are setting EGRESS_RATE_METER_EN_MASK bit (with a wrong value) in
> REG_EGRESS_RATE_METER_CFG register, egress QoS metering will not be supported
> yet since we are missing some other configuration (token bucket rate, token
> bucket size. Airoha folks please correct me if I am wrong). This is why I do
> not think it is important to backport this patch and I did not added any Fixes
> tag.
> QoS hw ingress/egress metering is in my ToDo list. Here I have ported the basic
> qos configuration I found in the vendor sdk. I will add more info in the commit
> log in v2. Sorry for the confusion.
> 
> Regards,
> Lorenzo


Thanks for explaining.